Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic: 'Original' text bubble in bottom-left disappears #69

Closed
WhosyVox opened this issue Sep 19, 2022 · 8 comments
Closed

Cosmetic: 'Original' text bubble in bottom-left disappears #69

WhosyVox opened this issue Sep 19, 2022 · 8 comments

Comments

@WhosyVox
Copy link

WhosyVox commented Sep 19, 2022

.. if you move the preview divider all the way to the left. This is not true for the bottom-right 'Upscayled' text bubble when moving the divider far to the right.

image

@NayamAmarshe
Copy link
Member

This is normal behavior. It happens for the right side as well:
image

@WhosyVox
Copy link
Author

WhosyVox commented Sep 20, 2022

This does not appear to be true on my side. Linux Mint 20.3, AppImage variant.

image

Regardless even if this behaviour was consistent, I would still consider it to be erroneous. The labels aren't canonically part of the image, so why does the slider have any effect upon them?

@NayamAmarshe
Copy link
Member

This does not appear to be true on my side. Linux Mint 20.3, AppImage variant.

image

Regardless even if this behaviour was consistent, I would still consider it to be erroneous. The labels aren't canonically part of the image, so why does the slider have any effect upon them?

This is consistent across all operating systems we've tested. Even MacOS:

image

I'll test another distro in a VM to see if it's the same there or not.

@NayamAmarshe
Copy link
Member

I'll reopen this issue for now, in case others report the same.

@NayamAmarshe NayamAmarshe reopened this Sep 20, 2022
@NayamAmarshe
Copy link
Member

Okay, I think I get why it's happening. Must be the PNG. The original image is supposed to overlay on top of the upscaled one, so since PNGs do not have a background, the title doesn't disappear. Interesting problem but a bit challenging since putting a solid background on PNGs could make things difficult.

@WhosyVox
Copy link
Author

I spent a while trying to figure this out myself testing landscape/portrait, etc. You're probably correct though. Nice catch.

If the background colour is identical to the background colour of the app itself, would that cause much of an issue at all? I guess it'd be something to test.

@NayamAmarshe
Copy link
Member

Yeah, I can fix it. Just not sure whether I should push a 1.5.1 just for this.

I think I'll get it fixed in v2 so closing the issue for now and adding it to my to-do. Thanks for reporting!

NayamAmarshe added a commit that referenced this issue Sep 25, 2022
JanDeDinoMan pushed a commit to JanDeDinoMan/upscayl that referenced this issue Sep 25, 2022
@NayamAmarshe
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants