-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix of job handling #18
Conversation
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
} | ||
} | ||
if len(st.errJobs) != 0 { | ||
return nil, errors.New(st.Detail()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the following issue.
#14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM - just a quick one though, this won't fix the issue we saw internally with some job being picked up incorrectly for the total number of jobs?
Also, you seem to have not included any fix for the verbose error message when the job fails? |
I think the implementation of this link has solved that problem.
if the job fails, we can get failed job name.ref: |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
This pr contains the following implementations.
skipped
, exclude this job from validation logic.