Fix Auto-pipeline Proxy Json Issue #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytkimirti
previously approved these changes
May 22, 2024
ogzhanolguncu
approved these changes
May 23, 2024
renovate bot
added a commit
to inabagumi/shinju-date
that referenced
this pull request
May 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@upstash/redis](https://togithub.com/upstash/upstash-redis) | [`^1.31.1` -> `^1.31.2`](https://renovatebot.com/diffs/npm/@upstash%2fredis/1.31.1/1.31.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>upstash/upstash-redis (@​upstash/redis)</summary> ### [`v1.31.2`](https://togithub.com/upstash/redis-js/releases/tag/v1.31.2) [Compare Source](https://togithub.com/upstash/upstash-redis/compare/v1.31.1...v1.31.2) #### What's Changed - Fix Auto-pipeline Proxy Json Issue by [@​CahidArda](https://togithub.com/CahidArda) in [upstash/redis-js#1080 **Full Changelog**: upstash/redis-js@v1.31.1...v1.31.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/inabagumi/shinju-date). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Since json commands are called with redis.json.get, redis.json returned the proxy and redis.json.get simply called the json.get of the pipeline of auto pipeline executor.
as response to redis.json.get, we simply returned the pipeline of auto executor with json.get called. This also added a command to the pipeline without incrementing
indexInCurrentPipeline, essentially corrupting the auto pipeline.Solution
Added a json parameter to
createAutoPipelineProxy. Returned a json proxy if command is json. Not the cleanest solution but it works.I feel like we can go over the types in the proxy later on. It looks a bit messy.