This repository has been archived by the owner on Nov 28, 2019. It is now read-only.
Fix for issue #60 #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @darshandoshi95 !! 😄 |
ntdef
suggested changes
Oct 25, 2018
There was a problem hiding this comment.
Hi @darshandoshi95, thanks again for your contribution! I took a look at your PR and compared them to the Dockerfile documentation. It expects key-value pairs like for example LABEL maintainer="Troy de Freitas <troy.defreitas@uptake.com>, Nick Paras <nick.paras@uptake.com>". I don't think your change would work as is... have you tried running it?
I think the example I added above might work.
|
@ntdef I've added the label @darshandoshi95 any interest in returning to this one? |
|
@jameslamb yeah, that's helpful! |
|
@darshandoshi95 are you able to come back and help us with this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So MAINTAINER was depreciated I have changed it to LABEL.