Add better handling for empty bucketed aggregation results #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 85.92% 86.08% +0.16%
==========================================
Files 9 9
Lines 604 611 +7
==========================================
+ Hits 519 526 +7
Misses 85 85
Continue to review full report at Codecov.
|
Merged
| @@ -102,7 +102,7 @@ cp ${SAMPLE_DATA_FILE} ${TESTDIR}/sample.json | |||
| cd ${TESTDIR} | |||
|
|
|||
| # give the cluster a chance | |||
| sleep 10 | |||
| sleep 15 | |||
There was a problem hiding this comment.
stuff happens, what can I say
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running an
aggsquery that is valid but returns no results is handled in a kind-of weird way. This PR just addresses it directly, catching the empty case and logging out the fact that it was empty with anINFOlevel statement.I don't think this fixes the issue that was reported in #58 (since that turned out to actually be about
reverse_nestedaggs), but gets us a bit closer.