release v0.3.0 #71
release v0.3.0 #71
Conversation
|
cc @staftermath check out all the new goodness! |
|
oh weird this is failing with the same error that was reported in #58 hmmmmmmmm |
tests/testthat/test-integration.R
Outdated
| @@ -166,9 +166,26 @@ futile.logger::flog.threshold(0) | |||
| expect_true(all(outDT[, doc_count > 0])) | |||
| }) | |||
|
|
|||
| # We have tests on static empty results, but this test will catch | |||
There was a problem hiding this comment.
whoops looks like I included this in a rebase when I shouldn't have! This will just get fixed when we merge #70 and then I'll rebuild. Sorry for the confusion
There was a problem hiding this comment.
like I accidentally committed the test but not the changes from #70 . I was just a fool in the way I did this...promise it will make sense when we merge that one
jameslamb
force-pushed
the
release/v0.3.0
branch
from
6b8ea90
to
284911a
Compare
| @@ -0,0 +1,85 @@ | |||
| $(function() { | |||
There was a problem hiding this comment.
ha yeah! this just came with pkgdown::build_site on the newest version
jameslamb
force-pushed
the
release/v0.3.0
branch
from
284911a
to
07914c1
Compare
|
I'd like #73 to make it out on this release as well, if it's not too controversial. Will update the NEWS.md and then try a CRAN submission once we merge that PR |
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 9 9
Lines 643 643
=======================================
Hits 559 559
Misses 84 84Continue to review full report at Codecov.
|
jameslamb
force-pushed
the
release/v0.3.0
branch
from
07914c1
to
31a0b6a
Compare
|
just submitted this for approval to CRAN! Will update the |
|
got accepted to CRAN. Merging this up!! Thanks @austin3dickey ! |
This PR adds a few more tweaks for us to push v0.3.0 to CRAN! See the diff on
NEWS.mdfor the highlights.I think we've added significant enough changes in the two months since v0.2.0 that a new release is warranted. Most notably support for Elasticsearch 6.x!
I would like #70 to make it onto this release if possible. Other than that, don't think anything is holding us up and we should be able to push to CRAN by the end of the week.