remove get_counts #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 86.93% 96.04% +9.11%
==========================================
Files 9 8 -1
Lines 643 582 -61
==========================================
Hits 559 559
+ Misses 84 23 -61Continue to review full report at Codecov.
|
austin3dickey
requested changes
Jun 11, 2018
austin3dickey
approved these changes
Jun 18, 2018
jameslamb
force-pushed
the
no_get_counts
branch
2 times, most recently
from
120081e
to
bbd56f2
Compare
|
#71 is merged and 0.3.0 is (out on CRAN!)[https://cran.r-project.org/web/packages/uptasticsearch/index.html] gonna merge this up as soon as travis builds |
|
very very excited to merge this one and simplify the package. This is the first step on our path from 0.3.0 to 1.0.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE YET.
This change will go out after we merge #71 and release v0.3.0 to CRAN. #69 added a deprecation warning on the
get_countsfunction that will ship to CRAN with the next release. This PR, which will be the first on the way to 0.4.0 (or maybe 1.0.0???), removesget_countsfrom the package. Unfortunately this didn't allow us to clean up the dependencies at all but it will simplify the package and make the philosophy ofuptasticsearchclearer.There are no tests in the diff because we never had any, which is fun.