Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages con guiones #191

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Packages con guiones #191

merged 2 commits into from
Jul 3, 2024

Conversation

ivojawer
Copy link
Contributor

  • Cambia el archivo de la validacion para archivos con caracteres invalidos
  • Cambia el test mas "basico" que encontre para que tambien pruebe que los packages/imports con guiones funcionan

@ivojawer ivojawer mentioned this pull request Jun 21, 2024
Merged
PalumboN
PalumboN approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podemos agregar un test que verifique que no se puede definir objectos/clases/mixines con -¿?

@ivojawer
Copy link
Contributor Author

Podemos agregar un test que verifique que no se puede definir objectos/clases/mixines con -¿?

Me quede pensando sobre esto y lo termine agregando del lado de ts, porque despues de todo deberia ser (y es) un error de parseo

@PalumboN PalumboN merged commit 8b0c726 into master Jul 3, 2024
@PalumboN PalumboN deleted the packages-with-dash branch July 3, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PalumboN PalumboN PalumboN approved these changes

@fdodino fdodino Awaiting requested review from fdodino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivojawer @PalumboN