Fix #1459 stack overflow ts wollok game #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
fdodino
approved these changes
Aug 13, 2018
| // TODO: Reportar un error del type system que sea más piola que Error in EValidator | ||
| log.fatal("Type inference failed", e) | ||
| } |
There was a problem hiding this comment.
🥇 Otra cosa que quiero agregar es un log.warning cuando corra el builder, para estar seguros que corrió el TS cuando corra el producto... que lo deje en el error log
There was a problem hiding this comment.
Sí. Un detalle ahí es que atrapa Exception y no Error. Es decir que si hubiera un Stack overflow seguiría pasando loq ue pasaba antes. Dudé de atrapar también error pero me pareció demasiado heavy. De hecho la política de Eclipse es que ante un stack overflow te propone reiniciar el Eclipse, desconfía de que las cosas puedan funcionar después de eso. Y lo mismo podría pasar con otros errores. Por eso no sé si es sano atrapar Error / Throwable.
No sé, por ahora le metí eso, es para pensar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.