Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1781 package json #1979

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Fix #1781 package json #1979

merged 2 commits into from
Dec 13, 2020

Conversation

fdodino
Copy link
Collaborator

@fdodino fdodino commented Nov 30, 2020 •
edited
Loading

See #1781

Generated package.json file:

{
  "name": "pry3",
  "version": "1.0.0",
  "wollokVersion": "3.0.0",
  "author": "dodain",
  "license": "ISC"
}
  • name: based on projectName
  • wollokVersion: based on Wollok.xtend VERSION static variable, which is automatically updated by the bash script
  • author: based on user logged

are dynamically generated.

@fdodino fdodino added this to the Wollok 3.0.0 J milestone Nov 30, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.195% when pulling 7d950af on fix-#1781-package-json into 24e1afc on dev.

PalumboN
PalumboN approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 👏 🆙

@fdodino fdodino merged commit 1183b94 into dev Dec 13, 2020
@fdodino fdodino deleted the fix-#1781-package-json branch December 13, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PalumboN PalumboN PalumboN approved these changes

@npasserini npasserini Awaiting requested review from npasserini

@nscarcella nscarcella Awaiting requested review from nscarcella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Wollok 3.0.0 J
Development

Successfully merging this pull request may close these issues.
3 participants
@fdodino @coveralls @PalumboN