-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_shutils when there is “python3” but no “python” #31
Fix test_shutils when there is “python3” but no “python” #31
Conversation
Can you clarify what your intended changes are doing, or what errors you may be seeing to trigger your changes? The intent of
The last case, using |
When building RPMs for Fedora Linux, there is no executable called My idea was that, if the test suite is invoked with something like If you don’t think this makes sense, we can always keep skipping the test in the RPM build, or carry a simpler downstream-only patch that simply replaces each |
Ah... ok. I see, that's a case I didn't plan for. How about something like this:
You can update the PR if that works for you. |
Thanks for the suggestion. I will update the PR. |
This allows the tests to pass in environments where there is a “python3” but no “python” in the executable search path.
ac49d0f
to
3929092
Compare
Thanks! |
thank you for the PR |
This allows the tests to pass in environments where the Python interpreter has some other name, such as “python3
”.This allows the tests to pass in environments where there is a “
python3
” but no “python
” in the executable search path.