-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urban airship is indirectly depending on insecure version of rest-client through unirest dependency #86
Comments
This is kinda of an issue huh |
is unirest being actively maintained? I see two unmerged PRs about this issue... it's also causing dependency issues. |
Hey, didn't even see this. I just submitted #94 to remove the Unirest dependency. |
hey @philtr what's the problem that your PR is not in master now? |
@nastia-shaternik if I remember correctly it didn't handle error responses quite as gracefully as Unirest. I was trying to use Net::HTTP instead. It would probably be a lot easier to move to RestClient instead if you want to take a stab at that. IMO API wrappers should use Net::HTTP, but I didn't have time to debug. |
This is now fixed, thanks for the report! |
[LIBS-180] Adds A/B Test Support to Ruby Lib
It would be nice to help
Mashape
to upgrade to newest version ofrest-client
The text was updated successfully, but these errors were encountered: