Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urban airship is indirectly depending on insecure version of rest-client through unirest dependency #86

Closed
paneq opened this issue Sep 15, 2015 · 6 comments

Comments

@paneq
Copy link

paneq commented Sep 15, 2015

It would be nice to help Mashape to upgrade to newest version of rest-client

@justinsoong
Copy link

This is kinda of an issue huh

@noam87
Copy link

noam87 commented Jan 27, 2016

is unirest being actively maintained? I see two unmerged PRs about this issue... it's also causing dependency issues.

@philtr
Copy link
Contributor

philtr commented Mar 12, 2016

Hey, didn't even see this. I just submitted #94 to remove the Unirest dependency.

@schaternik
Copy link

hey @philtr

what's the problem that your PR is not in master now?

@philtr
Copy link
Contributor

philtr commented Jul 16, 2016

@nastia-shaternik if I remember correctly it didn't handle error responses quite as gracefully as Unirest. I was trying to use Net::HTTP instead. It would probably be a lot easier to move to RestClient instead if you want to take a stab at that. IMO API wrappers should use Net::HTTP, but I didn't have time to debug.

@pdxmele
Copy link
Member

pdxmele commented Oct 24, 2016

This is now fixed, thanks for the report!

@pdxmele pdxmele closed this as completed Oct 24, 2016
sarahdactyl71 added a commit that referenced this issue Aug 31, 2020
[LIBS-180] Adds A/B Test Support to Ruby Lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants