Improve error handling for toStrict #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2024
Merged
arduano
force-pushed
the
pr129
branch
2 times, most recently
from
8915f4b
to
ba3739b
Compare
urbas
reviewed
May 14, 2024
src/eval/helpers.rs
Outdated
| }; | ||
| Ok(strict_nix_value) | ||
| } | ||
|
|
||
| pub fn call_applied_js_function<'s>( |
There was a problem hiding this comment.
Not sure what "applied function" means. Does it mean "instance method"? If so, could you please rename to:
pub fn call_js_instance_mehod<'s>(If not, could you add a comment explaining what an "applied" function is?
There was a problem hiding this comment.
Yeah I had a bit of a mind blank with this one. You can .apply on functions in js, but yeah this is just an instance method.
arduano
force-pushed
the
pr129
branch
2 times, most recently
from
2bf3fd5
to
09e395f
Compare
when calling `toStrict`, there was no try/catch for propagating the error back to Rust correctly. However, `call_js_function` didn't have the ability to correctly pass in the current `this` object to the function, so I made another function to handle it. In the future we should do a full cleanup of helper functions in general.
urbas
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling for toStrict
when calling
toStrict, there was no try/catch for propagating the error back to Rust correctly. However,call_js_functiondidn't have the ability to correctly pass in the currentthisobject to the function, so I made another function to handle it. In the future we should do a full cleanup of helper functions in general.Stack created with Sapling. Best reviewed with ReviewStack.