Propagate current path through the rust code #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2024
Merged
arduano
force-pushed
the
pr130
branch
3 times, most recently
from
c4a1f3d
to
13346e0
Compare
urbas
reviewed
May 15, 2024
src/eval/execution.rs
Outdated
| @@ -172,16 +171,11 @@ fn nix_value_from_module( | |||
| scope: &mut v8::ContextScope<v8::HandleScope>, | |||
| nix_value: v8::Local<v8::Function>, | |||
There was a problem hiding this comment.
Not related to your change, but I believe this variable has a misleading name. I think this should be nix_module_fn or something like that. If you agree, would you mind changing it while you're here?
urbas
reviewed
May 27, 2024
src/tests/mod.rs
Outdated
| Ok(val) => val, | ||
| Err(err) => panic!( | ||
| "eval '{}' shouldn't fail.\nError message: {}", | ||
| "eval '{}' shouldn't fail.\nError message: {:?}", |
There was a problem hiding this comment.
Total nitpick (feel free to ignore or do in a separate PR):
Suggested change
| "eval '{}' shouldn't fail.\nError message: {:?}", | |
| "eval '{nix_expr}' shouldn't fail.\nError message: {err:?}", |
Then the line below can be removed.
urbas
reviewed
May 27, 2024
src/tests/mod.rs
Outdated
| nix_expr, err | ||
| ), | ||
| } | ||
| } | ||
|
|
||
| fn eval_err(nix_expr: &str) -> NixErrorKind { | ||
| evaluate(nix_expr) | ||
| let workdir = std::env::current_dir().unwrap(); | ||
| evaluate(nix_expr, &workdir) | ||
| .expect_err(&format!("eval '{}' expected an error", nix_expr)) |
There was a problem hiding this comment.
Same as above (feel free to ignore etc.):
Suggested change
| .expect_err(&format!("eval '{}' expected an error", nix_expr)) | |
| .expect_err(&format!("eval '{}' expected an error", nix_expr)) |
Suggested change
| .expect_err(&format!("eval '{}' expected an error", nix_expr)) | |
| .expect_err(&format!("eval '{nix_expr}' expected an error")) |
There was a problem hiding this comment.
If you want these things to be picked up automatically, we can add clippy
urbas
previously approved these changes
May 27, 2024
Propagating current path (workdir) through the rust code.
urbas
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate current path through the rust code
Propagating current path (workdir) through the rust code.