Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Take %ask generator stuff out of sole- namespace #61

Closed
ohAitch opened this issue Mar 9, 2016 · 6 comments
Closed

Take %ask generator stuff out of sole- namespace #61

ohAitch opened this issue Mar 9, 2016 · 6 comments
Assignees
@baudtack @ohAitch
Labels
console enhancement tweaking or improving existing functionality

Comments

@ohAitch
Copy link
Contributor

ohAitch commented Mar 9, 2016

The bottom half of sur/sole concerns dojo generators, and uses only sole-prompt from the top half.
@ohAitch ohAitch self-assigned this Mar 9, 2016
@ohAitch
Copy link
Contributor Author

ohAitch commented Mar 9, 2016

(or lib/dojo)

@galenwp galenwp changed the title split lib/gen out of sur/sole Split lib/gen out of sur/sole Feb 8, 2017
@juped juped changed the title Split lib/gen out of sur/sole Take %ask generator stuff out of sole- namespace Feb 8, 2017
@belisarius222 belisarius222 added console enhancement tweaking or improving existing functionality labels Jan 19, 2018
@baudtack baudtack self-assigned this Oct 1, 2018
@baudtack
Copy link

baudtack commented Oct 2, 2018

This may be the wrong way to go about this but...

I'm writing up tutorials for generators and the awful names of the parts of %ask are annoying me so I'm trying to extract them from sur/sole into their own sur/ask lib.

There are two problems I am encountering.

  1. I've named all the gates ask-* which is not a great name so I need a better suggestion.
  2. I can't seem to boot a fakezod with the release-candidate branch of arvo right now. Not sure if that's a problem on my end or something in the repo. Either way I am unable to test my changes against it right now.

Any thoughts on either of these would be greatly appreciated.

@cgyarvin
Copy link
Contributor

cgyarvin commented Oct 2, 2018 via email

@cgyarvin
Copy link
Contributor

cgyarvin commented Oct 2, 2018 via email

@joemfb
Copy link
Member

joemfb commented Oct 2, 2018

@baudtack, the arms don't need to be prefixed in any way. Just give them meaningful names like "parse", "none", "prompt", etc. When you import the library with ford (/+ mylib), the names will be namespace'd by default (mylib:parse).

As for booting a fake-zod, make sure you have the release-candidate branch of both Arvo and vere, and use the -s option to find the latest pill.

baudtack pushed a commit to baudtack/arvo that referenced this issue Oct 2, 2018
Issue urbit#61
69b5c6f 
Extracted %ask generator methods from sur/sole and put them in a core
under lib/sole
Fixed names in existing generators
joemfb added a commit that referenced this issue Oct 12, 2018
@joemfb
Merge branch 'release-candidate' into ames-eth-keys
7c37816 
* release-candidate:
  moved to new branch with updated arvo
  11. demacrotizes %6, %7, %8, and %9
  10. updates %5 to require two subformulas (4K)
  9. emits %10 (4K)
  8. adds and implements edit (%10) (4K)
  7. removes %13 and %14 (4K)
  6. emits %11 and %12 (4K)
  5. implements hint at %11 and wish at %12 (4K)
  4. removes %10 and %11 (4K)
  3. emits %13 and %14 (4K)
  2. implements %13 and %14 (4K)
  1. duplicates hint (%10) and wish (%11) at %13 and %14 in +nock (4K)
  reinstated ++poke-lens-command with changes
  dojo: reinstate +he-lens with fixed +hoon
  adds a ^? to fix namespace issues with old-zuse
  removes now-unused web/pack file
  fixes userspace :test compilation failures
  refactored generators from lib/sole into lib/generators
  Issue #61
@joemfb
Copy link
Member

joemfb commented Dec 11, 2018

fixed in #829

@joemfb joemfb closed this as completed Dec 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@baudtack baudtack

@ohAitch ohAitch

Labels
console enhancement tweaking or improving existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@baudtack @cgyarvin @joemfb @belisarius222 @ohAitch