New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes |mass #1171
fixes |mass #1171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comment suggestions
I'm testing these printfs further, making sure they work with arbitrary structures and large amounts of data. I'll push some fixes soon. |
Can we save this output to a file? It would work nicer with this: urbit/arvo#1028 Maybe we should #define LOGGING or something for things like this. |
I feel like ideally we'd be uploading this data to https://docs.datadoghq.com/graphing or something similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a somewhat cursory read of this. Looks good.
I cleaned up the comments, and disabled printing of atoms larger than 10 words. The allocation-box heuristic printing is still crummy, but it's quite a bit better than it was. @ixv, I could thread a |
@ixv, configure meson with |
@philipcmonk, please re-review. |
refactors and unifies memory marking implementation for GC and
|mass