Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes |mass #1171

Merged
merged 8 commits into from Jan 30, 2019
Merged

fixes |mass #1171

merged 8 commits into from Jan 30, 2019

Conversation

joemfb
Copy link
Member

@joemfb joemfb commented Jan 29, 2019

refactors and unifies memory marking implementation for GC and |mass

Copy link
Contributor

@philipcmonk philipcmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comment suggestions

noun/allocate.c Outdated Show resolved Hide resolved
noun/allocate.c Outdated Show resolved Hide resolved
@joemfb
Copy link
Member Author

joemfb commented Jan 29, 2019

I'm testing these printfs further, making sure they work with arbitrary structures and large amounts of data. I'll push some fixes soon.

@ixv
Copy link
Contributor

ixv commented Jan 29, 2019

Can we save this output to a file? It would work nicer with this: urbit/arvo#1028

Maybe we should #define LOGGING or something for things like this.

@belisarius222
Copy link
Contributor

I feel like ideally we'd be uploading this data to https://docs.datadoghq.com/graphing or something similar.

Copy link
Contributor

@belisarius222 belisarius222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a somewhat cursory read of this. Looks good.

@joemfb
Copy link
Member Author

joemfb commented Jan 30, 2019

I cleaned up the comments, and disabled printing of atoms larger than 10 words. The allocation-box heuristic printing is still crummy, but it's quite a bit better than it was.

@ixv, I could thread a File* pointer instead of a loobean through all the mark functions -- that could default to stderr but pointed to some external file through a build option or something.

@joemfb
Copy link
Member Author

joemfb commented Jan 30, 2019

@ixv, configure meson with -Dmemory-log=true and every |mass effect will be written to pier/.urb/put/$DATE-mass.txt.

@joemfb joemfb requested a review from ixv January 30, 2019 03:22
@joemfb
Copy link
Member Author

joemfb commented Jan 30, 2019

@philipcmonk, please re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants