Update MAINTAINERS.md #6299
Merged
Update MAINTAINERS.md #6299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add post-release deployment instructions
zalberico
requested changes
Feb 7, 2023
zalberico
reviewed
Feb 7, 2023
|
Left a comment, but otherwise looks good - thanks! |
jalehman
commented
Feb 7, 2023
Comment on lines
+129
to
+132
| - [ ] Ensure that the release candidate was correctly propagated through the prerelease moons | ||
| - Use `-read %z ~SHIP %DESK da+now /` to check desk hashes | ||
| - [ ] Run the above check on the following [SHIP DESK] pairs: [~marnec-dozzod-marzod %base], [~marnec-dozzod-marzod %kids], [~doznec-dozzod-marzod %base], [~doznec-dozzod-marzod %kids] — **they should all match** | ||
| - [ ] Install the contents of the `%kids` desk on `~doznec-dozzod-marzod` into our `%base`: `|merge %base ~doznec-dozzod-marzod %kids, =gem %only-that` |
There was a problem hiding this comment.
the read command won't work if the clocks on the servers get out of sync for some reason, but otherwise should be fine (I typically just ssh into all of them myself)
zalberico
reviewed
Feb 7, 2023
MAINTAINERS.md
Outdated
| @@ -143,6 +146,17 @@ git push origin <tagname> | |||
| - [ ] Merge `master` back into `develop`. | |||
| - [ ] Cut a new release branch from `develop`. The branch should have the format `release/urbit-os-vX.XX` | |||
|
|
|||
| ### Release Next Release Candidate | |||
|
|
|||
| We'll now need to **IMMEDIATELY** deploy the new release candidate to the pre-release moons. | |||
There was a problem hiding this comment.
Might be worth explicitly saying before anything new merges into develop after branching for release (the why)?
There was a problem hiding this comment.
Deploying directly from release branches to marnec via tooling will fix this.
zalberico
previously approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add post-release deployment instructions