Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%clay $flue scry #6332

Merged
merged 5 commits into from Mar 3, 2023
Merged

%clay $flue scry #6332

merged 5 commits into from Mar 3, 2023

Conversation

tadad
Copy link
Contributor

@tadad tadad commented Feb 14, 2023

Resolves #6331

%pyro installs are quite slow because we cannot utilize the host ships's $flue cache. By adding the ability to scry this out, we can build desks on ships in seconds. I have a demo of this working here.

edit: I added the ability to scry out the entire dome. This also required a renaming of $dome:clay to $domo in lull.hoon, since now the entire $dome is in lull.

@tadad tadad marked this pull request as ready for review February 15, 2023 20:39
@belisarius222
Copy link
Contributor

This changes the return type of a scry, which would necessitate burning a Kelvin. We might be able to get away with not burning a Kelvin if we added a new scry instead, although it's somewhat questionable because an agent wouldn't be able to specify that it needs to be run in a kernel that has this scry as a capability.

Alternatively, we could merge this into the next Kelvin release. I think that's better, since the "domes" scry is more useful with this information in it, and duplicating the interface just to add the $flue cache strikes me as unclean. I won't officially approve this PR yet, until we're sure we're burning a Kelvin, but the code looks good. If we're not burning a Kelvin in this next release, then we will hold onto this work to be release when the next Kelvin goes out.

@tadad
Copy link
Contributor Author

tadad commented Feb 16, 2023

yeah I agree we should burn a kelvin.

I was also thinking maybe we should just scry out the entire dome (we only leave out two pieces from this scry now, mim (mime cache), and wic(commit in waiting). Unless there is something wrong with scrying the whole thing, it will let us get rid of some duplicated code between clay and lull.

@tadad
Copy link
Contributor Author

tadad commented Feb 17, 2023

just changed it so that you can scry out the entire $dome now. This moves $dome into lull.hoon, which made me have to change the name of $dome:clay to $domo:clay, which I think is better style

Copy link
Contributor

@belisarius222 belisarius222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should hold off on merging until we're ready to burn the next Kelvin.

@jalehman jalehman changed the base branch from develop to next/kelvin/414 March 3, 2023 15:17
@jalehman jalehman merged commit 17267a0 into urbit:next/kelvin/414 Mar 3, 2023
This was referenced Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%clay : $dome scry
3 participants