Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use branch for vere version #6372

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

matthew-levan
Copy link
Contributor

@matthew-levan matthew-levan commented Mar 4, 2023

Resolves #6370.

@jalehman Should we be using next/* for our "release branch" pattern? We could use next/kelvin/* or next/release/* as well. Thoughts appreciated. See release.yml for where we use it.

cc @philipcmonk @zalberico

@matthew-levan matthew-levan force-pushed the i/6370/use-branch-for-vere-version branch 2 times, most recently from 188f0a7 to 2e658ee Compare March 4, 2023 16:42
jalehman
jalehman previously approved these changes Mar 4, 2023
Copy link
Member

@jalehman jalehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming I haven't missed something, pending the change to use live on master this looks good to go.

.github/workflows/master.yml Outdated Show resolved Hide resolved
Copy link
Member

@jalehman jalehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. Per our discussion, we'll re-add the ability to pin to a specific vere version with a future PR.

@matthew-levan matthew-levan marked this pull request as ready for review March 14, 2023 17:55
@matthew-levan matthew-levan merged commit 425a207 into develop Mar 14, 2023
@matthew-levan matthew-levan deleted the i/6370/use-branch-for-vere-version branch March 14, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: use branch instead of .vere-version to download binary
2 participants