sss: Distinguish between an empty path and a wiped path #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6397
Forgot a step in my
;:chain, and had the wrong "base case". Also cleaned up the logic,?:seems clearer than?..The logic here is: When trying to serve a wave
w'that doesn't exist, we only assume that it was deleted (i.e. send a%yore)wexists, then only ifw' < wrexists, then only ifw' ≤ r.In all other cases, including when neither
wnorrexist, the requested wave is in the future and should result in a%nigh.Shout out to @rabsef-bicrym who discovered the mistake. :)
Side note: using the irregular forms of tisgal and miccol together seems to break Github's syntax highlighting. Do we know who is responsible for this?