Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen: add +ames-keys generator #6586

Merged
merged 2 commits into from
May 16, 2023
Merged

gen: add +ames-keys generator #6586

merged 2 commits into from
May 16, 2023

Conversation

yosoyubik
Copy link
Contributor

Fixes #6584

belisarius222
belisarius222 approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@belisarius222 belisarius222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could unlink the dojo if you ask about a ship we haven't talked to yet, but it's still an improvement over not having this generator.

@joemfb
Copy link
Member

joemfb commented May 15, 2023

Last I checked, failed scrys in generators just print a trace -- they don't unlink the dojo the way raw expressions do.

@belisarius222 belisarius222 merged commit 0113f8a into develop May 16, 2023
1 check passed
@belisarius222 belisarius222 deleted the i/6584/rift-life-gen branch May 16, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belisarius222 belisarius222 belisarius222 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: generator to scry for rift and life in ames state
3 participants
@yosoyubik @joemfb @belisarius222