Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta: this is hotpatched directly onto ~dem. Nothing should be released before this, or if it is, then this should be re-hotpatched onto ~dem.
Galaxies process a lot of pings, and in 413K, the time required to process pings regressed by roughly 10x, to around 30-40ms each. In the 413K refactoring around requests for remote scry, we started checking whether a requested hash was in the "reachable takos" of a desk before we could approve the request. Unfortunately, for many live ships, this process takes more than 10ms.
There are several possible mitigations, two of which are implemented here.
%noun
mark, and Gall dutifully tries to build the%noun
mark in order to validate that the untyped noun it received is in fact an untyped noun. There's no point to that, so this PR short-circuits in that case.My tests indicate that the changes in this PR reduce ~dem's ping processing times from about 45ms to 4-5ms.
Separately, I would expect anything that makes a lot of Clay requests, even if they're mostly cache hits, to be significantly sped up by this PR.