Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify +vats usage in +vat deprecation msg #6590

Merged
merged 1 commit into from
May 16, 2023

Conversation

ngzax
Copy link
Contributor

@ngzax ngzax commented May 16, 2023

Describe the bug
+vat has been deprecated. when you run it it gives the message "Notice: +vat is deprecated as +vats now takes lists of one or more desks"

this prompted me to try +vats ~[%base %garden] which fails. I assert that this is the correct interpretation of the message above.

I propose to change the message to: "Notice: +vat is deprecated as +vats now takes one or more desks as arguments. e.g. '+vats %base %garden'"

Additional context
This is a simple one-liner that may prevent frustration in others as well. Especially until the docs are updated.

Notify maintainers
@joemfb

tested on local planet by copying over new vat.hoon and running |commit %base.

output:

> +vat %base
%base
  /sys/kelvin:      [%zuse 413]
  base hash:        0v19.lu2ua.0tfl3.v6nek.5oog0.9obm0.3fsdl.8gj4d.rrkg0.ur2ts.f0rjg
  %cz hash:         0v1e.lal9a.kaklo.2ibft.64kec.eokma.57q3u.fu40r.2ijkq.2n8gp.4c0q5
  app status:       running
  force on:         ~[%eth-watcher]
  force off:        ~
  publishing ship:  ~
  updates:          remote
  source ship:      ~darlur
  source desk:      %kids
  source aeon:      134
  kids desk:        %kids
  pending updates:  ~
::
Notice: +vat is deprecated. use +vats which now takes one or more desks as arguments. e.g. '+vats %base %garden'

Copy link
Member

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@joemfb joemfb merged commit 75901eb into urbit:develop May 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants