New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clay: print download progress for desk updates #6873
Draft
yosoyubik
wants to merge
20
commits into
develop
Choose a base branch
from
yu/rate
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+582
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This connects %hood to the console and, although not currently used, adds the sole-id to %kiln, for possible later use in printing more fine-grained information about desks' state. Another option could be to have a separate console-enabled agent that manages any information that needs to be printed, and then %kiln or the related strandio threads can just poke it (this will possible end up recreating the state stored in %kiln)
|
This let us download date that takes longer than the ~m5 scry-timeout using %fine, and not falling back to %ames
Currently this only supports the view of how many paths are in flight. The facilities for knowing the the size of any/all paths in the desk are in place but are still a work in progress. There is also a thread (-whit) that calculates the size of data at a path based on the number of fragments and the size of each, as sent by the publisher.
|
This is really great work! A thought that comes to mind: Having this in the dojo as toggle-able behavior is desirable. It'll also be the case that many applications that eventually leverage fine for pulling content from other nodes will also want to be able to display download bandwidth/progress. Providing documentation on how it works as a guide in the docs should accompany its release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
(Note: possible alternative version of #6867; instead of scrying the rate out of
%ames
we rely on%ames
notifying any subscribers for a%keen
—In this case%clay
, which will just send the%rate
%gift
to%kiln
. Leaving as a draft so we can compare what approach is more ergonomic and also to consider a better UI for displaying the progress)