Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagoon IEEE 754 floats #6971

Open
wants to merge 6 commits into
base: next/kelvin/410
Choose a base branch
from
Open

Conversation

sigilante
Copy link
Contributor

Pursuant to draft UIP at https://github.com/urbit/UIPs/blob/sigilante/lagoon-reals/UIPS.

Should be released alongside corresponding Vere code.

@mopfel-winrux
Copy link
Contributor

++ de-ray does not work with leading zeros. need to fix before merging

@sigilante
Copy link
Contributor Author

Incidentally, test failure is because I included some older ones that shouldn't be in there. I'll clean it up later.

@sigilante
Copy link
Contributor Author

+de-ray fixed.

Tests fixed.

@sigilante
Copy link
Contributor Author

test-urbit> clay: read-at-tako fail [desk=%base care=%a case=[%da p=~2024.5.2..20.40.45..de52] path=/gen/tx/hoon]
test-urbit> [%file-not-found-mist /tests/lib/naive/hoon]
test-urbit> [%error-validating /tests/lib/naive/hoon]
test-urbit> [%error-building /tests/lib/naive/hoon]
test-urbit> [%error-building /gen/tx/hoon]
test-urbit> clay: %a build failed [%base 0v1o.trqdf.gvsr6.07kka.joa89.97t9h.btt65.4a3b2.m0q1g.tgj1n.koh9e /gen/tx/hoon]
test-urbit> FAILED  /gen/tx/hoon

AFAICT nothing to do with Lagoon.

@sigilante
Copy link
Contributor Author

Thanks. Guess things are getting moved around.

test-urbit> clay: read-at-tako fail [desk=%base care=%a case=[%da p=~2024.5.3..16.15.42..287f] path=/ted/ph/tend/hoon]
test-urbit> [%file-not-found-mist /tests/app/tend/hoon]
test-urbit> [%error-validating /tests/app/tend/hoon]
test-urbit> [%error-casting-path /tests/app/tend/hoon ~.hoon %hoon]
test-urbit> [%error-building /ted/ph/tend/hoon]
test-urbit> clay: %a build failed [%base 0v1o.trqdf.gvsr6.07kka.joa89.97t9h.btt65.4a3b2.m0q1g.tgj1n.koh9e /ted/ph/tend/hoon]
test-urbit> FAILED  /ted/ph/tend/hoon
test-urbit> %some-threads-failed

test-urbit> clay: read-at-tako fail [desk=%base care=%c case=[%da p=~2024.5.3..16.16.10..f350] path=/noun/mass]
test-urbit> clay: no files match /mar/mass/hoon
test-urbit> [%error-building-cast %noun %mass]
test-urbit> [%error-building-tube %noun %mass]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants