Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various text-oriented wrapper libraries. #6988

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

sigilante
Copy link
Contributor

Add alternative functions for common text conversion operations.

@will-hanlen
Copy link
Contributor

could the second half of this be simplified by using +slavs instead of +slaws?

++  text-to-ship  (cury slav %p)

or is there some advantage to using the unitized version?

@sigilante sigilante marked this pull request as ready for review May 14, 2024 19:35
@sigilante
Copy link
Contributor Author

Per conversation with @belisarius222 ~2024.5.23, I have collected all of the strictly text-related libraries into one PR. These are explicitly NOT kelvin-versioned, and consist of wrappers, aliases, and simple helper functionality.

@tinnus-napbus generating documentation should be straightforward as all of the functions are documented in each file, including examples.

@sigilante sigilante changed the title Add /lib/text for mortals. Add various text-oriented wrapper libraries. May 23, 2024
@sigilante
Copy link
Contributor Author

I guess /lib/bits is not technically part of this scope.

@jalehman
Copy link
Member

Deadline for review is tomorrow, at which point if there are no comments we'll go ahead and merge.

@tinnus-napbus
Copy link
Contributor

I have opened PR #7020 with optimisations for some of the functions in libstring & fixed a couple of functions that were incorrect (right-find, right-justify and arguably split which wasn't adding an empty string after a trailing separator).

I will look at the other 2 quickly tomorrow. Sorry for not getting around to it earlier

@tinnus-napbus
Copy link
Contributor

ok I have opened PR #7021 with some changes to the other 2 libs (see PR for details) - not sure if you want the utf changes I made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants