Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoon: retain face on type in +lose:ar (for ?#) #6994

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented May 21, 2024

?# wuthax was stripping faces in some type subtraction scenarios, which is unexpected and undesirable.

Excluding .skin doesn't necessarily mean we lose any of .ref's faces. The %base and %leaf cases were already retaining them, we now do so for the %cell case too.

Previously:

> =+  l=(gulf 0 5)
> ?<  ?#([one=@ two=@ rest=~] l)  l
[i=0 [i=1 t=[i=2 t=~[3 4 5]]]]

Now:

> =+  l=(gulf 0 5)
> ?<  ?#([one=@ two=@ rest=~] l)  l
[i=0 t=[i=1 t=[i=2 t=~[3 4 5]]]]

Excluding .skin doesn't necessarily mean we lose any of .ref's faces.
The %base and %leaf cases were already retaining them, we now do so for
the %cell case too.

Co-authored-by: joemfb <joemfb@gmail.com>
@Fang- Fang- added the hoon label May 21, 2024
@Fang- Fang- requested a review from joemfb May 21, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant