Create /lib/math. #7000
Merged
Create /lib/math. #7000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deadline for review is tomorrow, at which point if there are no comments we'll go ahead and merge. |
|
I am not very happy with the current algorithm on some of the transcendental functions. I used Taylor expansion instead of Chebyshev functions, which is much slower for smaller rtols. I will be changing these out in the upstream urbit/numerics repo at some point; when I do things like that, I'll just PR them as updates here so we at least have this distributed. (This is why I haven't jetted these yet.) |
jalehman
previously approved these changes
Jul 8, 2024
jalehman
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream lives in urbit/numerics repo, but this distributes via
%base.