Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate git history from Urbit monorepo #38

Merged
merged 4 commits into from Dec 15, 2022

Conversation

mcevoypeter
Copy link

Description

Resolves #31. This PR makes small changes needed to account for the version bump from v1.10 to v1.13. For context, the extraction of the runtime from urbit/urbit began when the runtime was at v1.10, and it's now at v1.13. Rebasing issue/1/bazel-build onto the tip of next/vere (which is at 71d06e544f7fe641ac0a9dad1fe07576761227ec as of the time of this writing) wasn't quite sufficient; this PR adds the few small changes needed to bring this repo fully up-to-date, namely:

  • Define U3_GUARD_PAGE.
  • Bump version number to 1.13.
  • Add test targets for newly introduced tests.
  • Set default memo cache size.

Testing

$ bazel test //...
$ bazel build :urbit
$ bazel-bin/pkg/vere/urbit -F zod -B solid.pill
$ bazel-bin/pkg/vere/urbit -c comet -B solid.pill

Note the testing required a non-default pill (i.e. solid.pill) because the default pill URL (https://bootstrap.urbit.org/props/1.13/brass.pill) doesn't have a pill yet.

@mcevoypeter mcevoypeter linked an issue Dec 15, 2022 that may be closed by this pull request
@mcevoypeter mcevoypeter merged commit c433a12 into issue/1/bazel-build Dec 15, 2022
@matthew-levan
Copy link
Contributor

When branching this runtime-specific repo off from the urbit monorepo, we initially based off of next/vere in the monorepo. However, during the course of fall 2022, buggy work ended up on next/vere. Because of this, the release branch for version 1.14 of the runtime branched off of master, not next/vere, leading to a non-trivial divergence between next/vere and master. To that end, we have to rewrite the history of this repo, which will potentially obfuscate the commit SHAs and diffs of the already merged PRs in this repo. To provide a trail of breadcrumbs, attached is a patch of the diff represented by this PR before history was rewritten.

PR38.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate git history from Urbit monorepo
2 participants