Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLAKE3 jets #535

Merged
merged 6 commits into from
Jan 25, 2024
Merged

BLAKE3 jets #535

merged 6 commits into from
Jan 25, 2024

Conversation

lukechampine
Copy link
Contributor

@lukechampine
Copy link
Contributor Author

Anyone on a beefy amd64 machine want to benchmark this? I'm on an M2, so I can't see those juicy AVX-512 speedups. 😭 Still, ~1.2 GB/s ain't bad -- that's 2x faster than sha3, and 4x faster than blake2b.

@belisarius222
Copy link
Contributor

It looks like there's some git churn here. Maybe merge develop into your branch?

@joemfb joemfb changed the base branch from develop to msl/fetch-urcrypt October 17, 2023 21:41
@matthew-levan matthew-levan force-pushed the msl/fetch-urcrypt branch 2 times, most recently from cf391f7 to 17e57e0 Compare November 15, 2023 21:05
@matthew-levan matthew-levan deleted the branch urbit:develop November 15, 2023 21:26
@joemfb joemfb reopened this Nov 15, 2023
@joemfb joemfb changed the base branch from msl/fetch-urcrypt to develop November 15, 2023 21:27
lukechampine
lukechampine commented Nov 26, 2023
View reviewed changes
pkg/noun/jets/e/blake.c Outdated Show resolved Hide resolved
@lukechampine lukechampine marked this pull request as ready for review November 27, 2023 01:56
@lukechampine lukechampine requested a review from a team as a code owner November 27, 2023 01:56
joemfb
joemfb requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good. I've noted a couple issues with one allocation, and an assertion that should be removed.

These jets will go into 411 (or later), so they should not be declared in the hoon %140 cores. I've setup the declarations for 411 (hoon 138) in #567, it'll be simplest for this PR to target that one.

pkg/noun/jets/e/blake.c Outdated Show resolved Hide resolved
pkg/noun/jets/e/blake.c Outdated Show resolved Hide resolved
pkg/noun/jets/e/blake.c Outdated Show resolved Hide resolved
pkg/noun/jets/e/blake.c Outdated Show resolved Hide resolved
pkg/noun/jets/e/blake.c Outdated Show resolved Hide resolved
pkg/noun/jets/e/blake.c Show resolved Hide resolved
pkg/noun/jets/tree.c Outdated Show resolved Hide resolved
joemfb
joemfb approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will do

@joemfb joemfb merged commit 60986d3 into urbit:develop Jan 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemfb joemfb joemfb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukechampine @belisarius222 @joemfb @matthew-levan