Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zuse: add blake3 #6802

Merged
merged 9 commits into from Apr 24, 2024
Merged

zuse: add blake3 #6802

merged 9 commits into from Apr 24, 2024

Conversation

lukechampine
Copy link
Contributor

BLAKE3 is the faster, cleaner, more powerful successor to BLAKE2. In particular, it is a tree hash -- the digest is a Merkle root -- which means it can be used for verified streaming.

pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
@belisarius222
Copy link
Contributor

belisarius222 commented Sep 28, 2023 via email

@belisarius222
Copy link
Contributor

Ah, email comments can't do markdown. Here's better formatting:

|%  ::  zuse or lull
::  ...
++  blake3
  =<  run
  |%
  ++  run
    |=(* !!)
  ++  compress
    |=(* !!)
  --
::  ...
--

pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
Copy link
Member

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. A few nits:

pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
Copy link
Member

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look right. The jet declaration hints need to be tweaked to be hierarchical, and adding an assertion will make the relevant jet simpler.

This PR should target next/kelvin/411.

pkg/arvo/sys/zuse.hoon Show resolved Hide resolved
pkg/arvo/sys/zuse.hoon Show resolved Hide resolved
pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
@joemfb
Copy link
Member

joemfb commented Dec 7, 2023

Instead of directly targeting next/kelvin/411, this can be built on top of #6859 (until it and the relevant vere pr are merged).

pkg/arvo/sys/zuse.hoon Outdated Show resolved Hide resolved
joemfb added a commit to urbit/vere that referenced this pull request Jan 25, 2024
@joemfb joemfb changed the base branch from develop to next/kelvin/410 April 24, 2024 15:40
Copy link
Member

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will do

@joemfb joemfb merged commit d2a3255 into urbit:next/kelvin/410 Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants