Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all "stringly typed" fields #415

Closed
meatballhat opened this issue May 18, 2016 · 0 comments
Closed

Remove all "stringly typed" fields #415

meatballhat opened this issue May 18, 2016 · 0 comments
Assignees
@meatballhat
Labels
kind/feature describes a code enhancement / feature request status/claimed someone has claimed this issue
Milestone
v2.0.0

Comments

@meatballhat
Copy link
Member

No description provided.

@meatballhat meatballhat added this to the v2.0.0 milestone May 18, 2016
meatballhat added a commit that referenced this issue May 20, 2016
@meatballhat
Flag and FlagSet (re)implementation
616a69d 
plus:

- removing stringly typed flag names and env vars
- switching to pointer receivers all over

Closes #415
meatballhat added a commit that referenced this issue May 22, 2016
@meatballhat
Replace all "stringly typed" fields with slice equivalents
81fcf70 
and alter the Flag interface accordingly

Closes #415
@meatballhat meatballhat mentioned this issue May 22, 2016
Merged
@codegangsta codegangsta added the status/claimed someone has claimed this issue label May 22, 2016
@meatballhat meatballhat changed the title Remove all "stringly" typed fields Remove all "stringly typed" fields May 22, 2016
@meatballhat meatballhat added the kind/feature describes a code enhancement / feature request label May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meatballhat meatballhat

Labels
kind/feature describes a code enhancement / feature request status/claimed someone has claimed this issue
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@meatballhat @codegangsta