Replace all "stringly typed" fields with slice equivalents #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and alter the Flag interface accordingly Closes #415
| return fmt.Sprintf("%s\t%s", prefixedNames(names, placeholder), usageWithDefault) | ||
| } | ||
|
|
||
| func hasFlag(flags []Flag, fl Flag) bool { |
There was a problem hiding this comment.
Whoops! Thanks for catching that 😸
On Sat, May 21, 2016, 22:08 Jesse Szwedko notifications@github.com wrote:
In flag.go
#419 (comment):@@ -683,5 +715,15 @@ func stringifySliceFlag(usage, name string, defaultVals []string) string {
}usageWithDefault := strings.TrimSpace(fmt.Sprintf("%s%s", usage, defaultVal))
- return fmt.Sprintf("%s\t%s", prefixedNames(name, placeholder), usageWithDefault)
- return fmt.Sprintf("%s\t%s", prefixedNames(names, placeholder), usageWithDefault)
+}
+func hasFlag(flags []Flag, fl Flag) bool {
Is this called anywhere?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/codegangsta/cli/pull/419/files/81fcf706ea1c2bdde52d04088a9c5b0bc1a97f7a#r64142989
|
👏 this is great, one question, otherwise |
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and alter the Flag interface accordingly
Closes #415
This PR was extracted from #418.