Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more k8s/release friendly PR template. #1035

Merged
merged 3 commits into from
Jan 13, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
59 changes: 36 additions & 23 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,38 +4,44 @@
If a section of the PR template does not apply to this PR, then delete that section.
-->

## Motivation
## What type of PR is this?

_(fill-in or delete this section)_
_(REQUIRED)_

- [ ] bug
- [ ] cleanup
- [ ] documentation
- [ ] feature

## What this PR does / why we need it:

_(REQUIRED)_

<!--
What goal is this change working towards?
If this PR fixes one of more issues, list them here.
One line each, like so:
Fixes #123
Fixes #39
Provide a bullet pointed summary of how each file was changed.
Briefly explain any decisions you made with respect to the changes.
Include anything here that you didn't include in *Release Notes*
above, such as changes to CI or changes to internal methods.
-->

## Release Notes

_(fill-in or delete this section)_
## Which issue(s) this PR fixes:

_(REQUIRED)_
<!--
If this PR makes user facing changes, please describe them here.
This description will be copied into the release notes, whenever
the next version is released. Keep this section short, and
focus on high level changes.
If this PR fixes one of more issues, list them here.
One line each, like so:
Fixes #123
Fixes #39
-->

## Changes
## Special notes for your reviewer:

_(fill-in or delete this section)_

<!--
Provide a bullet pointed summary of how each file was changed.
Briefly explain any decisions you made with respect to the changes.
Include anything here that you didn't include in *Release Notes*
above, such as changes to CI or changes to internal methods.
Is there any particular feedback you would / wouldn't like?
Which parts of the code should reviewers focus on?
-->

## Testing
Expand All @@ -46,11 +52,18 @@ _(fill-in or delete this section)_
Describe how you tested this change.
-->

## Reviewer Guidelines

_(fill-in or delete this section)_
## Release Notes

_(REQUIRED)_
<!--
Is there any particular feedback you would / wouldn't like?
Which parts of the code should reviewers focus on?
If this PR makes user facing changes, please describe them here. This
description will be copied into the release notes/changelog, whenever the
next version is released. Keep this section short, and focus on high level
changes.

Put your text between the block. To omit notes, use NONE within the block.
-->

```release-note

```