Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash/ZSH auto-complete docs #905

Closed
wants to merge 6 commits into from
Closed

Bash/ZSH auto-complete docs #905

wants to merge 6 commits into from

Conversation

masonj5n
Copy link
Contributor

@masonj5n masonj5n commented Oct 6, 2019

Closes #863

Here's a first pass of updating the docs. Hopefully I cleared up the process of enabling auto-completion. I added some examples of what the auto-complete looks like, they're links to giphy.com, not sure if it'd be better to store the gifs themselves instead of having links. If they don't look like they belong we can definitely remove them. Let me know though and I'll make changes!

@masonj5n masonj5n requested a review from a team as a code owner October 6, 2019 05:50
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@coilysiren
Copy link
Member

Thanks for helping out @masonj88 ✨ it's nearly there 👍

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #905 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   71.38%   71.38%           
=======================================
  Files          30       30           
  Lines        2394     2394           
=======================================
  Hits         1709     1709           
  Misses        578      578           
  Partials      107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a221e66...e36e86a. Read the comment docs.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@coilysiren
Copy link
Member

Oh, this has merge conflicts now because the documentation has moved!

You'll want to make these same changes against the v2 manual file now https://github.com/urfave/cli/blob/master/docs/v2/manual.md

@masonj88

@masonj5n
Copy link
Contributor Author

I'll have it done soon!

@daxmc99
Copy link

daxmc99 commented Feb 5, 2020

Any update on this? Would it be ok if I made another PR to resolve these merge conflicts? This doc is sorely needed

@coilysiren
Copy link
Member

@daxmc99 please do!

@coilysiren
Copy link
Member

closing this as stale

@coilysiren coilysiren closed this Feb 5, 2020
@coilysiren
Copy link
Member

@masonj188 feel free to race @daxmc99 for this PR 😆 but otherwise you can ignore this

@masonj5n
Copy link
Contributor Author

masonj5n commented Feb 6, 2020

Really sorry for taking so long, just opened a new pull request for the merge into the new master!

@daxmc99 daxmc99 mentioned this pull request Feb 6, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash completion: documentation not understandable
4 participants