-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme for the v2 merge #924
Conversation
_(title)_
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
=======================================
Coverage 72.89% 72.89%
=======================================
Files 32 32
Lines 2439 2439
=======================================
Hits 1778 1778
Misses 550 550
Partials 111 111 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too
@@ -18,7 +18,7 @@ applications in an expressive way. | |||
Usage documentation exists for each major version | |||
|
|||
- `v1` - [./docs/v1/manual.md](./docs/v1/manual.md) | |||
- `v2` - 🚧 documentation for `v2` is WIP 🚧 | |||
- `v2` - [./docs/v2/manual.md](./docs/v2/manual.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a note that this belongs to the master branch as well? (See #925)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a note that this belongs to the master branch as well? (See #925)
Since we require 2 approving reviews, I'll do this in a followup PR
(title)