-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix values & combinations #29
Comments
Hi First category fails because you cannot combine prefix and explode as of RFC6570 Section 2.4 Second category is currently discussed here: #27 . I hope that helped |
Thanks, @hannesg |
Hi Andrej, of course for a 100% compliant implementation you could use my https://github.com/fxa/uritemplate-js https://github.com/fxa/uritemplate-js ;-) But if you prefer to write your own, please make a performance diff check and inform me! Franz Von: Andrei Neculau [mailto:notifications@github.com] Thanks, @hannesg https://github.com/hannesg — |
@fxa :) yes, I know about your lib as well. Thank you I prefered not to write my own, but to improve @hannesg implementation because
Don't take this at heart, but that's the honest truth as to my drive. FYI currently the implementation is 99% compatible with uritemplate-tests, and I'm awaiting some answers in #21 (comment) regarding the failing testcases -- maybe you have some input? PS: performance is important, but long-term it's even more important to have readable code. Even so - quick comparisons of running all tests (227) at once give |
Of course I don’t take this at heart ;-) I just don’t like coffee script, because it is the attempt to build a language within another language, Here rebuild ruby with javascript. And that did not work with groovy and the guava lib. If you want to program with ruby, just take ruby. If you want to program functional in the jvm, take scala. But don’t use a hybrid. But that is just my 2cents. For the moment I am implementing some crypto javascript, So I am very focused to performance ;-) It is not funny to see, when chrome needs just 80ms and IE8 on the same machine more than 6 seconds. Franz Von: Andrei Neculau [mailto:notifications@github.com] @fxa https://github.com/fxa :) yes, I know about your lib as well. Thank you I prefered not to write my own, but to improve @hannesg https://github.com/hannesg implementation because
Don't take this at heart, but that's the honest truth as to my drive. FYI currently the implementation is 99% compatible with uritemplate-tests, and I'm awaiting some answers in #21 #21 (comment) regarding the failing testcases -- maybe you have some input? PS: performance is important, but long-term it's even more important to have readable code. Even so - quick comparisons of running all tests (227) at once give real 0m0.707s;user 0m0.225s;sys 0m0.043s. Come back with your timings :) — |
errata: "but to improve __ @grncdr __ implementation because" |
I'm contributing to a URI template lib (JS), which uses PEG - grncdr/uri-template#6
and the grammar actually parses some of the templates in negative-tests.json, instead of failing:
Why should the first category fail, rather than expand into "He" ?
As for the second category, I'm assuming it should fail because prefixed values are incompatible with lists/maps - can someone confirm ?
Thanks
The text was updated successfully, but these errors were encountered: