Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to uritemplate-test #6

Merged
merged 17 commits into from
May 21, 2013
Merged

Switch to uritemplate-test #6

merged 17 commits into from
May 21, 2013

Conversation

andreineculau
Copy link
Collaborator

I wanted to use uri-template, but before I do I'd like it to pass all uritemplate-test, made of

  • official tests included in the RFC
  • semi-official tests written by Mark Nottingham, Erik Wilde & co

Current status:
Failed 39 (26 PEG) out of 227 tests

  • 26 PEG - the PEG parser failed to parse the URI template; the rest of the failures is that the library expanded into a different URI

@andreineculau
Copy link
Collaborator Author

Note: I'm trying to work out those failures

@andreineculau
Copy link
Collaborator Author

Failed 14 (0 PEG) out of 227 tests

Only expansion failures left

@andreineculau
Copy link
Collaborator Author

Failed 2 (0 PEG) out of 227 tests

I'm waiting for a reply on the remaining 2 failing testcases at uri-templates/uritemplate-test#21
And I have some fixes that I'm in doubt whether it's a proper fix, or I've committed code just to get around some bad testcases uri-templates/uritemplate-test#29

Over and out. Awaiting feedback

@grncdr
Copy link
Owner

grncdr commented May 21, 2013

Wow, thanks for putting so much work into this. I've done a quick review and it looks good to me. I will have to take a look at the uritemplate-test issues you pointed out, but I'm happy to merge this for now, and have given you commit access for future changes.

grncdr added a commit that referenced this pull request May 21, 2013
@grncdr grncdr merged commit d22b335 into grncdr:master May 21, 2013
@andreineculau
Copy link
Collaborator Author

Cool. And thank you.
It looks like the work so far that the uritemplate-tests are backed up by the RFC, so my changes are correct.

Still waiting for input regarding the last 2 failing testcases at uri-templates/uritemplate-test#21
IMHO I think the current implementation is correct; the tests are not. But that's just too easy :)

@andreineculau andreineculau mentioned this pull request May 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants