Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change content-type header to use application/x-ndjson #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change content-type header to use application/x-ndjson #58

wants to merge 1 commit into from

Conversation

chemass
Copy link

@chemass chemass commented Mar 13, 2020

because application/json does not work.

@eran-gil
Copy link
Collaborator

I think it's better you move it to a configuration parameter where the default value is the current one.
Then everyone will be able to make their choice for the content type.

eran-gil
eran-gil requested changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@eran-gil eran-gil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to configuration with the default value of the new parameter being the current state.

@eran-gil eran-gil force-pushed the master branch 2 times, most recently from afffd78 to 07c0b49 Compare April 9, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eran-gil eran-gil eran-gil requested changes

@urielha urielha Awaiting requested review from urielha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chemass @eran-gil @CCoxshall