Adding the Mel and Log Mel spectrograms. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlthome
reviewed
Jan 9, 2024
…ead of the compute_features method.
…in two features being computed, which does not seem expected. Should be fixed.
|
Oh wow, that's fantastic, thank you! Should I wait for the TODO feature computation before merging this, @ax-le ? |
|
Never mind, I see you're addressing this here #157 Merging away, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! And Happy New Year!
This pull request aims at implementing two additional features: the Mel and the Log Mel spectrograms.
The Mel filter bank is defined following [1] (i.e. 80 mel coefficients, with a min frequency of 80Hz, and a max frequency of 16kHz.
Note that these Mel spectrograms were developed for signals sampled at 44.1kHZ with 2048 samples per window, while, in the current implementation of MSAF, signals are sampled at 22.05kHz with 4096 frames per window. It should be discussed how to solve that ambiguity (divide by two the max frequency? Change the sampling rate for Mel spectrograms?).
Let me know if I can improve the code in any way!
References
[1] Ullrich, K., Schlüter, J., & Grill, T. (2014, October). Boundary Detection in Music Structure Analysis using Convolutional Neural Networks. In ISMIR (pp. 417-422).