TypeError: Cannot read property 'utc' of undefined

[ColonelBundy]

This is now fixed, It was a nw.js issue.
See: #196 For more details.

[urish]

Can you verify that moment is loaded into your page successfully?

Please try opening the chrome devtools and typing there moment, check what the it says...

Thx

[ColonelBundy]

moment
\moment\moment.js:15 function utils_hooks__hooks() {
        return hookCallback.apply(null, arguments);
    }

First thing I did before creating this post :)

[urish]

thanks, are you using the latest version of angular-moment? that is 1.0.0-beta.2

[ColonelBundy]

used bower to install so I guess yes?

Also checked top of the js file : /* angular-moment.js / v0.10.3 / (c) 2013, 2014, 2015 Uri Shaked / MIT Licence */

well I guess no now when I checked the repo compared to my js file.

[urish]

bower install does not currently pull the beta version, please try installing the beta by writing:

bower i -S angular-moment#1.0.0-beta.2

thanks!

[ColonelBundy]

TypeError: undefined is not a function
    at preprocessDate (angular-moment.js:396)
    at updateMoment (angular-moment.js:251)
    at Object.fn (angular-moment.js:269)

Still..

[urish]

Can you put a breakpoint at angular-moment.js line 98 and see what the value of moment is there?

thx

[ColonelBundy]

TypeError: undefined is not a function
    at angular.module.constant.constant.constant.directive.service.preprocessDate (VM1188 angular-moment.js:396)
    at updateMoment (VM1188 angular-moment.js:251)
    at Object.fn (VM1188 angular-moment.js:269)

[urish]

For some reason, moment is not defined when angular-moment is being loaded. Can't really tell you why it is happening without seeing the entire codebase, but if you could create a small sample that reproduces it I'd be able to look into it

[ColonelBundy]

I can do that certainly, But I came to believe now it might be nw.js (formerly known as node-webkit) that is the culprit here?

EDIT: tried using npm and: var moment = require('moment'); still no dice.

[urish]

Actually yes, see #104

[ColonelBundy]

I actually looked over that issue before I created this, and thought I post anyways. But as you can see even using node.js's require doesn't work.

[urish]

Can you try changing line 662 to read:

angularMoment(require('angular'), moment);

instead of

angularMoment(require('angular'), require('moment'));

and check if it fixes the issue ?

[ColonelBundy]

same error still..

[urish]

Interesting... Are you using moment 2.10.3? Someone noted on #104 that upgrading to 2.10.3 helped solve a similar problem with nw.js

[ColonelBundy]

I was using 2.10.6, downgraded to 2.10.3, still no dice.

[urish]

So both when using bower and npm, moment comes out undefined in the context of angular-moment?

[ColonelBundy]

That's right.

[urish]

Okay, do you want to try debugging it and coming back with some conclusions why it happens? Alternatively, if you can create a small example that reproduces this behavior, I can look into it...

[ColonelBundy]

Okay, kind of "solved" it...

var moment1 = require('moment');
.constant('moment', moment1)

But got a deprecation warning saying moment falls back to js Date and everything becomes "Invalid date."

[urish]

Do you get the warning when using $scope.date = new Date()?

The deprecation warnings appears when you pass moment a string instead of a Date object...

[ColonelBundy]

Do you get the warning when using $scope.date = new Date()?

Yes.

The deprecation warnings appears when you pass moment a string instead of a Date object...

Yea I read about that @ the linked github issue.

[urish]

Seems like others are also facing similar issues, e.g. nwjs/nw.js#2075.

Very strange that the Date stuff doesn't work - can you please double-verify by logging the value which is passed to preprocessDate in line 396?

[ColonelBundy]

It returns nothing, its blank. Thought I broke it at first but its just nothing... It no longer says invalid date though... but nothing gets returned.

[urish]

and what does it get (inside the value parameter, in line 396)?

does value instanceof Date evaluate true at that line?

Uri

[ColonelBundy]

I feel embarrassed... Sorry for taking up your time on this latest issue of the new Date() thing... I accidentally closed down my powershell which had gulp watch running... Took me a while to figure out why the hell my js didnt update... Well I got the am-time-ago working in a ng-repeat a little while ago and I was stunned the new Date() thing didn't... So again I'm sorry..

However, Now when its working wonders I would like to give me two thanks for helping me with this, you've been really helpful! Not many people I know are being this helpful and actually taking the time to resolve it.

I would also like to add, If you could do a check for moment already before:

function angularMoment(angular, moment)

And then throw an error if you can't find it, Would make sense right? it would be really helpful for others. And also, document the solution I had to use to make it work for nw.js would also be helpful for others.

Again, thank you very much!

[urish]

No worries :)

Yes, I think that adding a check at the beginning of the function and throwing a more descriptive error if moment is undefined makes a lot of sense. If you have some time to create a PR for it, that will be awesome!

Uri

[ColonelBundy]

PR submitted.

[urish]

great!

On Sun, Nov 8, 2015 at 3:23 AM, Marcus notifications@github.com wrote:

PR submitted.

—
Reply to this email directly or view it on GitHub
#194 (comment)
.

[urish]

Fixed by #196