Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Added support for nw.js #196

Merged
merged 1 commit into from
Nov 8, 2015
Merged

Added support for nw.js #196

merged 1 commit into from
Nov 8, 2015

Conversation

ColonelBundy
Copy link
Contributor

Lets make jshint happy!

Lets make jshint happy!
urish added a commit that referenced this pull request Nov 8, 2015
@urish urish merged commit 08f805b into urish:master Nov 8, 2015
@urish
Copy link
Owner

urish commented Nov 8, 2015

looks great!

So what would be the steps for using angular-moment with nw.js? Perhaps you could add it to the README and send a PR, in favor of other nw.js / angular-moment users?

@ColonelBundy
Copy link
Contributor Author

So what would be the steps for using angular-moment with nw.js? Perhaps you could add it to the README and send a PR, in favor of other nw.js / angular-moment users?

Well, npm install moment would do the trick, I wanted to modify the readme but then I included the "step" if you are using nw.js/browserify (require function) in the code itself. See: https://github.com/urish/angular-moment/blob/master/angular-moment.js#L17

Since the error tells you to reference to the readme I could write something though.

What do you think?

@urish
Copy link
Owner

urish commented Nov 8, 2015

Yea, that makes perfect sense :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants