Remove "!" character from the "unreserved" characters in IPv6 Zone ID…

… parsing
urllib3 · Jan 29, 2023 · 29c4bcc · 29c4bcc
1 parent 96588e9
commit 29c4bcc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/changelog/2899.bugfix.rst b/changelog/2899.bugfix.rst
@@ -0,0 +1 @@
+Removed '!' from _UNRESERVED_PAT as specified in the RFC.
diff --git a/src/urllib3/util/url.py b/src/urllib3/util/url.py
@@ -48,9 +48,7 @@
     "(?:(?:%(hex)s:){0,6}%(hex)s)?::",
 ]
 
-_UNRESERVED_PAT = (
-    r"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789._!\-~"
-)
+_UNRESERVED_PAT = r"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789._\-~"
 _IPV6_PAT = "(?:" + "|".join([x % _subs for x in _variations]) + ")"
 _ZONE_ID_PAT = "(?:%25|%)(?:[" + _UNRESERVED_PAT + "]|%[a-fA-F0-9]{2})+"
 _IPV6_ADDRZ_PAT = r"\[" + _IPV6_PAT + r"(?:" + _ZONE_ID_PAT + r")?\]"