Wrap OpenSSL SysCallError on send as well as recv #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
=========================================
+ Coverage 97.71% 100% +2.28%
=========================================
Files 21 21
Lines 1926 1926
=========================================
+ Hits 1882 1926 +44
+ Misses 44 0 -44
Continue to review full report at Codecov.
|
|
This looks reasonable enough to me. It'd be nice to have a test for this, but we don't have a good framework for testing this module right now and I am not going to ask you to start one for this PR. Thanks! 👍 |
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
…tions Wrap OpenSSL SysCallError on send as well as recv
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Add CHANGES for urllib3#1125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a similar issue as described in #367, occasionally getting "SysCallError: (104, 'Connection reset by peer')" on sending through the requests library. As I understand it, it should be intercepted and wrapped here.