Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection pooling behavior when maxsize > 1 #13

Merged
merged 1 commit into from
Jan 29, 2012
Merged

Fix connection pooling behavior when maxsize > 1 #13

merged 1 commit into from
Jan 29, 2012

Commits on Nov 29, 2011

  1. Fix connection pooling behavior when maxsize > 1 

    The connection pool's underlying Queue.Queue (a FIFO queue) is prefilled
with None objects; therefore, until you make maxsize HTTP requests, no
connections will be reused. I've attached a test which demonstrates this
(and now passes after switching to Queue.LifoQueue.)

The requests library defaults to a pool size of 10, which exposes this
bug.
    @berg
    berg committed Nov 29, 2011
    1 Configuration menu
    Copy the full SHA
    5de8335 View commit details
    Browse the repository at this point in the history