Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable skip_host and skip_accept_encoding #138

Closed
wants to merge 1 commit into from

Conversation

kanzure
Copy link

@kanzure kanzure commented Dec 31, 2012

Py2.4 added skip_host and skip_accept_encoding to httplib, but it's only
available when manually sending data over the wire with connect() and
putheader().

In httpconnection.py, httplib and http.client are wrapped with a small
fix to enable support for skip_host and skip_accept_encoding.

Also unit tests.

Py2.4 added skip_host and skip_accept_encoding to httplib, but it's only
available when manually sending data over the wire with connect() and
putheader().

In httpconnection.py, httplib and http.client are wrapped with a small
fix to enable support for skip_host and skip_accept_encoding.

Also unit tests.
@shazow
Copy link
Member

shazow commented Dec 31, 2012

Hmm could you talk about when this is necessary?

First I've seen this request and I'd rather avoid adding too much niche functionality in the core library.

@kanzure
Copy link
Author

kanzure commented Dec 31, 2012

There are some finnicky servers out there that I have encountered that completely explode when they are given an "Accept-Encoding" header. Obviously, these servers are wrong, but I would still very much like to use Requests.

@shazow
Copy link
Member

shazow commented Dec 31, 2012

Doesn't sound like @kennethreitz wants to include this in Requests either way.

I like having complete control of headers but perhaps we're better off reserving this for when we drop dependency on httplib (#58). I feel the pull as is adds more mess and complexity than the functionality is worth at this time. :)

@shazow shazow closed this Dec 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants