Skip otherwise mandatory headers #1077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows requests to specify whether or not to include these two headers. This feature was originally added to httplib in py2.4 to skip the "Host" header or skip the "Accept-Encoding" header for particularly annoying servers.
|
This is related to urllib3/urllib3#138 where I have submitted the underlying urllib3 changes. |
|
Thanks for the pull request, but this is unnecessary. If you really want to enable this functinality for yourself, you can create a new connection adapter to behave exactly as you expect. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for skip_host and skip_accept_encoding. I bet there are a lot
of ways this could be refactored to not be completely all over the place. This
enables a feature in httplib and http.client from all the way back in py2.4 to
enable/disable the "Host" and "Accept-Encoding" headers.
This breaks a test in urllib3 and the same problem appears in the requests
tests. Hopefully someone can help look into why this test is failing in both
cases.