-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test-pypy3.8 test-pypy3.9 test-pypy3.10 #3304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think lint is failing? You will need to run nox -rs format
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
This would be interesting to understand why we have so many issues with PyPy. Any ideas? |
Well, I actually noticed that I don't really understand yet, why the test under pypy3.9 are sometimes very very slow (it takes more than 30 minutes to get to 50% of the test suite) , I want to check if that is something that happens only on the GItHub Actions / CI or if it is something that I can replicate with pypy3.9 locally. I just wrote an issue to track the the pypy on ci problems: #3305 |
@ecerulm Can you resolve the conflicts on this PR with the 3.9 one that I just merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on your changes to the contributing docs.
Currently there are nox session for
test-3.8
,test-3.9
,test-3.10
,test-3.11
andtest-pypy
.Then
test-pypy
is should in my opinion be split intotest-pypy3.8
,test-pypy3.9
, andtest-pypy3.10
since that is already done in CI. It easier to run multiple pypy locally in the laptop if those nox sessions are explicit.With this PR is possible to run the nox sessions for all pypy versions like so
The rational behind this PR is to be able to run the pypy tests locally in my computer for pypy3.8, pypy3.9 and pypy3.10 without having to delete the
.nox/pypy
in between. Also I think for consistency with the cpython tests where there is a separate nox session for each one.This PR has #3286 as prerequisite though.