Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout to 4.1.4 #3387

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 23, 2024

Bumps actions/checkout from cd7d8d697e10461458bc61a30d094dc601a8b017 to 9b4c13b0bfa31b4514c14f74b5a166c2708f43c6.

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.1.2

v4.1.1

v4.1.0

v4.0.0

v3.6.0

v3.5.3

v3.5.2

v3.5.1

v3.5.0

v3.4.0

v3.3.0

v3.2.0

... (truncated)

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
actions/checkout [< 5, > 4.0.0]

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/checkout](https://github.com/actions/checkout) from cd7d8d697e10461458bc61a30d094dc601a8b017 to 9b4c13b0bfa31b4514c14f74b5a166c2708f43c6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@cd7d8d6...9b4c13b)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file Skip Changelog Pull requests that don't require a changelog entry labels Apr 23, 2024
@dependabot dependabot bot requested a review from illia-v as a code owner April 23, 2024 12:58
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 23, 2024

The following labels could not be found: github_actions.

@pquentin
Copy link
Member

The versions in comments do not seem correct here. Also the commits chosen are not even tags or releases?

@sethmlarson
Copy link
Member

@pquentin What might be happening is:

  • Dependabot wants to upgrade us to the latest release/commit (v4.1.4)
  • It sees we're using commit SHAs so it uses the commit SHA for v4.1.4 (9b4c13b0bfa31b4514c14f74b5a166c2708f43c6)
  • It also sees we have a comment, but after checking the comment it sees the tag referenced in the comment doesn't match the tag on the actions/checkout repository
  • Because the comment doesn't match an expected tag Dependabot thinks this comment is something we want preserved (because maybe it's a documenting comment) so doesn't modify it
  • Resulting in this strange diff where the commit is updated but not the tag comment.

Can't be certain, but that at least makes sense to me?

@pquentin pquentin changed the title Bump actions/checkout from cd7d8d697e10461458bc61a30d094dc601a8b017 to 9b4c13b0bfa31b4514c14f74b5a166c2708f43c6 Bump actions/checkout to 4.1.4 Apr 25, 2024
@pquentin
Copy link
Member

That's certainly plausible! I manually fixed the SHAs and comments in f1fc865 (#3387), let's see if that puts dependabot on the right track again.

@pquentin pquentin merged commit b34619f into main Apr 26, 2024
68 checks passed
@pquentin pquentin deleted the dependabot/github_actions/actions/checkout-9b4c13b0bfa31b4514c14f74b5a166c2708f43c6 branch April 26, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants