Further improvements to pyopenssl sendall() #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't currently do anything useful, because PyOpenSSL needs to convert back to a string to pass to ffi. It doesn't hurt, though.
| @@ -204,10 +207,12 @@ def _send_until_done(self, data): | |||
| continue | |||
|
|
|||
| def sendall(self, data): | |||
| if sys.version_info >= (2, 7) and not isinstance(data, memoryview): | |||
There was a problem hiding this comment.
Would be better to check for the presence of memoryview rather than check sys.version_info.
Maybe something like this near the top?
try:
_ = memoryview
has_memoryview = True
except NameError:
has_memoryview = False
shazow
added a commit
that referenced
this pull request
May 18, 2015
Further improvements to pyopenssl sendall()
|
Thanks for the improvements, I appreciate you following up on this. :) Btw you're welcome to add yourself to our CONTRIBUTORS.txt file! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address the feedback from #626 and #627